merge libdeno::DenoIsolate into core::Isolate#3605
Merged
Conversation
bartlomieju
commented
Jan 5, 2020
bartlomieju
commented
Jan 5, 2020
bartlomieju
commented
Jan 5, 2020
This reverts commit 2f8d986.
bartlomieju
changed the title
ry
reviewed
Jan 6, 2020
| /// behaves much like an Arc<[u8]>, although a PinnedBuf currently can't be | ||
| /// cloned. | ||
| #[allow(unused)] | ||
| pub struct PinnedBuf { |
Member
Author
There was a problem hiding this comment.
backing_store field is unused, I'll move attribute
ry
reviewed
Jan 6, 2020
ry
reviewed
Jan 6, 2020
| pub unsafe fn deno_snapshot_delete(s: &mut deno_snapshot) { | ||
| todo!() | ||
| } | ||
| */ |
ry
reviewed
Jan 6, 2020
ry
reviewed
Jan 6, 2020
| pub struct Worker { | ||
| pub name: String, | ||
| isolate: Arc<Mutex<deno_core::Isolate>>, | ||
| isolate: Arc<Mutex<Box<deno_core::Isolate>>>, |
Member
There was a problem hiding this comment.
@piscisaureus Are you ok with forcing users of deno_core to use Box<Isolate> ?
ry
reviewed
Jan 6, 2020
ry
left a comment
ry
left a comment
Member
There was a problem hiding this comment.
LGTM - nice work - I'd like to have @piscisaureus give it a glance before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.