fix(ext/node): respect base64 buffer ranges#36030
Merged
Merged
Conversation
nathanwhit
marked this pull request as ready for review
July 14, 2026 02:44
bartlomieju
changed the title
bartlomieju
approved these changes
Jul 14, 2026
bartlomieju
pushed a commit
that referenced
this pull request
Jul 15, 2026
## Summary - validate internal base64 slice and write ranges before invoking native operations - limit base64 decoding to the caller-requested destination span - make the underlying base64 operations reject invalid ranges consistently The base64 write path previously decoded into the full remaining buffer and only clamped the returned byte count afterward. This change bounds the destination view before decoding and adds range checks at both the JavaScript adapter and native operation layers. ## Testing - `cargo build --bin deno` - `target/debug/deno test -A --config tests/config/deno.json tests/unit_node/buffer_test.ts` - `./tools/format.js` - `cargo fmt --check --package deno_web --package deno_node`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The base64 write path previously decoded into the full remaining buffer and only clamped the returned byte count afterward. This change bounds the destination view before decoding and adds range checks at both the JavaScript adapter and native operation layers.
Testing
cargo build --bin denotarget/debug/deno test -A --config tests/config/deno.json tests/unit_node/buffer_test.ts./tools/format.jscargo fmt --check --package deno_web --package deno_node