fix(ext/node): handle UTF-16 assert source positions#36029
Merged
bartlomieju merged 1 commit intoJul 14, 2026
Conversation
nathanwhit
marked this pull request as ready for review
July 14, 2026 02:24
bartlomieju
changed the title
bartlomieju
approved these changes
Jul 14, 2026
bartlomieju
pushed a commit
that referenced
this pull request
Jul 15, 2026
## Summary - translate V8 UTF-16 source columns to checked UTF-8 byte offsets - fall back to the full source line when a reported position is not a valid character boundary - keep the final assertion-expression slice checked ## Why The `node:assert` source-expression formatter receives a UTF-16 column from V8 but slices a Rust UTF-8 string. The previous approximation handled some non-ASCII text but could produce an invalid byte boundary for multibyte characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The
node:assertsource-expression formatter receives a UTF-16 column from V8 but slices a Rust UTF-8 string. The previous approximation handled some non-ASCII text but could produce an invalid byte boundary for multibyte characters.Validation
./tools/format.jscargo fmt --check --package deno_nodeCARGO_TARGET_DIR=target cargo test -p deno_node ops::assert::tests --lib -- --nocaptureCARGO_TARGET_DIR=target cargo build --bin denotarget/debug/deno test -A tests/unit_node/assert_test.ts