fix(node): handle sqlite conversion failures#36024
Merged
bartlomieju merged 1 commit intoJul 14, 2026
Merged
Conversation
nathanwhit
marked this pull request as ready for review
July 13, 2026 23:14
bartlomieju
approved these changes
Jul 14, 2026
bartlomieju
pushed a commit
that referenced
this pull request
Jul 15, 2026
This makes `node:sqlite` treat JavaScript conversion failures as normal, catchable errors. V8 property and index access can execute JavaScript and fail, while C string conversion rejects embedded null bytes. The affected statement binding, tag store, function and aggregate option, iterator setup, and session option paths now propagate those failures instead of assuming conversion always succeeds. Result and error properties are also defined directly to avoid invoking inherited setters. After a failed conversion, the database remains usable by subsequent operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
node:sqlitetreat JavaScript conversion failures as normal, catchable errors.V8 property and index access can execute JavaScript and fail, while C string conversion rejects embedded null bytes. The affected statement binding, tag store, function and aggregate option, iterator setup, and session option paths now propagate those failures instead of assuming conversion always succeeds. Result and error properties are also defined directly to avoid invoking inherited setters.
After a failed conversion, the database remains usable by subsequent operations.
Validation:
./tools/format.jscargo fmt --check --package deno_node_sqlitecargo build --bin denotests/unit_node/sqlite_test.tssuite (82 tests)