fix(ext/node): guard sqlite deserialize during callbacks#36023
Merged
nathanwhit merged 1 commit intoJul 14, 2026
Conversation
nathanwhit
marked this pull request as ready for review
July 13, 2026 23:14
bartlomieju
changed the title
bartlomieju
approved these changes
Jul 14, 2026
bartlomieju
pushed a commit
that referenced
this pull request
Jul 15, 2026
This prevents `DatabaseSync.deserialize()` from replacing database contents while a user-defined SQLite callback is active. `deserialize()` finalizes existing statements, so calling it reentrantly could invalidate the statement SQLite is currently executing. The method now uses the existing callback-depth guard and returns `ERR_INVALID_STATE`, matching `DatabaseSync.close()` behavior. Validation: - `./tools/format.js` - `cargo build --bin deno` - focused `DatabaseSync.deserialize` callback regression - full `tests/unit_node/sqlite_test.ts` suite (78 tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents
DatabaseSync.deserialize()from replacing database contents while a user-defined SQLite callback is active.deserialize()finalizes existing statements, so calling it reentrantly could invalidate the statement SQLite is currently executing. The method now uses the existing callback-depth guard and returnsERR_INVALID_STATE, matchingDatabaseSync.close()behavior.Validation:
./tools/format.jscargo build --bin denoDatabaseSync.deserializecallback regressiontests/unit_node/sqlite_test.tssuite (78 tests)