fix(core): block user ext imports after resolution#36012
Merged
nathanwhit merged 2 commits intoJul 14, 2026
Conversation
nathanwhit
marked this pull request as ready for review
July 13, 2026 19:30
bartlomieju
approved these changes
Jul 14, 2026
bartlomieju
pushed a commit
that referenced
this pull request
Jul 15, 2026
This keeps internal `ext:` module loading tied to the resolved module context. The module map now rejects resolved internal module specifiers when they are requested from ordinary file modules, including after loader resolution. This also covers `node:vm` default-loader paths where filenames can be caller-controlled. Tests: - `cargo test -p deno_core module_map_rejects_user_ext_imports_after_resolution -- --nocapture` - `cargo test -p unit_node_tests --test unit_node -- unit_node::vm_test --nocapture` - `cargo fmt --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps internal
ext:module loading tied to the resolved module context.The module map now rejects resolved internal module specifiers when they are requested from ordinary file modules, including after loader resolution. This also covers
node:vmdefault-loader paths where filenames can be caller-controlled.Tests:
cargo test -p deno_core module_map_rejects_user_ext_imports_after_resolution -- --nocapturecargo test -p unit_node_tests --test unit_node -- unit_node::vm_test --nocapturecargo fmt --check