fix: don't print duplicate parse diagnostics#35933
Merged
Merged
Conversation
swc can report the same fatal parse diagnostic more than once (ex.
`for (console.log("a") of [1]);`). deno_ast surfaces every collected
diagnostic, so the identical error was printed twice, both in the repl
and when running a file.
Collapse identical diagnostics before the transpile error is reported.
bartlomieju
pushed a commit
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swccan report the exact same fatal parse diagnostic more than once.deno_astcollects every fatal diagnostic intoParseDiagnosticsError, whoseDisplayprints each one, so the identical error was shown twice:The same duplication happens for
deno run main.tson that source, since both paths surfacedeno_ast::TranspileError.This collapses identical diagnostics (
ParseDiagnosticcompares specifier + range + kind) while preserving order, at the point the transpile error is produced. Distinct diagnostics are still all reported.Fixes #27804