feat: Return null on error in Deno.dir()#3531
Merged
Merged
Conversation
ry
reviewed
Dec 20, 2019
nayeemrmn
force-pushed
the
dir-fallback
branch
from
December 20, 2019 22:10
e215323 to
fd78710
Compare
nayeemrmn
changed the title
ry
reviewed
Dec 20, 2019
ry
left a comment
ry
left a comment
Member
There was a problem hiding this comment.
Maybe permission errors should still throw
nayeemrmn
force-pushed
the
dir-fallback
branch
from
December 20, 2019 23:10
95175ed to
5e9719b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful here because it would save a lot oftry/catchblocks for what is a common pattern, even if it seems higher order.