Skip to content

feat: Add Deno.dir("executable")#3526

Merged
ry merged 2 commits into
denoland:masterfrom
nayeemrmn:executable-dir
Dec 21, 2019
Merged

feat: Add Deno.dir("executable")#3526
ry merged 2 commits into
denoland:masterfrom
nayeemrmn:executable-dir

Conversation

@nayeemrmn

Copy link
Copy Markdown
Contributor

cc @axetroy

Was there some reason this was omitted? I'm thinking about using it for deno install.

Comment thread cli/js/lib.deno_runtime.d.ts
@nayeemrmn

Copy link
Copy Markdown
Contributor Author

@ry Please review.

Comment thread cli/js/os.ts

@ry ry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry
ry merged commit f07ffe8 into denoland:master Dec 21, 2019
@nayeemrmn
nayeemrmn deleted the executable-dir branch December 21, 2019 12:37
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants