fix(ext/node): implement worker_threads.isInternalThread#35234
Merged
Conversation
node:worker_threads did not export isInternalThread (added in Node v23.7.0 / v22.14.0), so both the named import and the property on the default/require object were missing. Add it to the exports object with a constant value of false, since Deno has no internal Node worker threads. Closes #35149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node:worker_threadsdid not implementisInternalThread, so both thenamed import and the property on the default/
requireobject weremissing:
isInternalThreadwas added in Node v23.7.0 / v22.14.0. It is a booleanindicating whether the code runs inside an internal Node worker thread
(such as a module loader thread), as distinct from
isMainThread. It isfalsein the main thread and in user-created workers.In the polyfill the synthetic ESM export names are derived from the keys
of the exports object, so adding
isInternalThreadthere exposes it bothas a named export and as a property of the default/
requireobject.Deno has no internal Node worker threads, so the value is a constant
false.Closes #35149