fix(ext/web): repair text_decoder_stream bench after BlobStoreTrait change#35044
Merged
Conversation
…hange #34000 changed deno_web::init to take an Arc<dyn BlobStoreTrait>, but the text_decoder_stream benchmark still passed Default::default() for that argument, which no longer compiles. Construct the blob store explicitly with Arc::new(BlobStore::default()).
bartlomieju
enabled auto-merge (squash)
June 8, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#34000 changed deno_web::init to accept an Arc for
its blob store argument. The text_decoder_stream benchmark still passed
Default::default() there, which no longer satisfies the trait bound, so
the bench failed to compile and broke the lint job on every PR.
Construct the blob store explicitly with Arc::new(BlobStore::default()),
matching how the runtime sets it up elsewhere.