feat(ext/node): notify control socket when node:http server starts serving#34949
Merged
bartlomieju merged 1 commit intoJun 5, 2026
Merged
Conversation
…rving Upstream PR denoland#34662 landed the DENO_SERVE_ADDRESS override for node:http/node:https, and PR denoland#34676 wired Deno.serve() to call `op_http_notify_serving()` so that DENO_AUTO_SERVE setups can wait for a "Serving" event over DENO_UNSTABLE_CONTROL_SOCK. Node servers were left out: they observed the override address but never fired the notification, so a control plane waiting on the socket would hang. This hooks `notifyAddressOverrideServing()` into the listen() path of both `http.Server` and `https.Server` (and into `startOverrideListener` for non-TCP override transports) so node:http servers fire the same notification that Deno.serve() does. The unconfigured spec gains a node:http variant exercising the full DENO_AUTO_SERVE + DENO_SERVE_ADDRESS=duplicate,unix:... + DENO_UNSTABLE_CONTROL_SOCK flow.
Deno Individual Contributor License AgreementThe following contributors need to sign the CLA before this PR can be merged: Click here to review and sign the CLA | Re-run CLA check This is an automated message from CLA Assistant |
bartlomieju
enabled auto-merge (squash)
June 5, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR #34662 landed the
DENO_SERVE_ADDRESSoverride fornode:http/node:https, and PR #34676 wiredDeno.serve()to callop_http_notify_serving()so thatDENO_AUTO_SERVEsetups can wait for a"Serving" event over
DENO_UNSTABLE_CONTROL_SOCK. Node servers were left out:they observed the override address but never fired the notification, so a
control plane waiting on the socket would hang.
This hooks
notifyAddressOverrideServing()into thelisten()path of bothhttp.Serverandhttps.Server(and intostartOverrideListenerfor non-TCPoverride transports) so
node:httpservers fire the same notification thatDeno.serve()does. The unconfigured spec gains anode:httpvariantexercising the full
DENO_AUTO_SERVE+DENO_SERVE_ADDRESS=duplicate,unix:...+DENO_UNSTABLE_CONTROL_SOCKflow.