fix(clean): support deno clean --dry-run without --except#34846
Merged
Conversation
Previously '--dry-run' required '--except', so 'deno clean --dry-run' errored out. Allow it on its own: it now walks the cache directory, reports how many files and how much space would be removed, and does not delete anything. Closes #30031
Run the no-`--except` dry-run through the same output path as a real clean so it prints the identical `Removed <path> (<N> files, <size>)` line, then a trailing `Aborting due to --dry-run flag` notice instead of a separate `Would remove` wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
deno clean --dry-runerrored out because--dry-runrequired--exceptto be passed alongside it, which is surprising: a dry run isexactly when you would not want to commit to also cleaning everything
except some paths. It now works on its own and walks the cache directory
to report how many files and how much space would be removed, without
deleting anything.
This also closes a latent footgun: the no-
--exceptclean path neverconsulted the
dry_runflag, so simply relaxing the argumentrequirement would have made
--dry-rundelete the whole cache. Thedry-run branch now short-circuits before any removal happens.
Closes #30031