fix(node): prevent buffer decode detach race#34632
Merged
Merged
Conversation
Co-Authored-By: Divy Srivastava <[email protected]>
divybot
changed the title
Co-Authored-By: Divy Srivastava <[email protected]>
littledivy
approved these changes
Jun 1, 2026
littledivy
added a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
Fix a reentrancy-sensitive Buffer decode path by parsing slice indexes before borrowing ArrayBufferView contents, then reacquiring the contents after any user-defined coercion can run. Mark the op reentrant because V8 integer coercion can execute JS and invoke other ops. Add a unit-node regression that detaches the backing ArrayBuffer during utf8Slice index coercion and verifies the operation fails safely instead of using stale memory. Tests: - cargo fmt --check - cargo build --bin deno - cargo test -p unit_node_tests --test unit_node -- buffer Closes denoland/divybot#441 --------- Co-authored-by: divybot <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a reentrancy-sensitive Buffer decode path by parsing slice indexes before borrowing ArrayBufferView contents, then reacquiring the contents after any user-defined coercion can run. Mark the op reentrant because V8 integer coercion can execute JS and invoke other ops.
Add a unit-node regression that detaches the backing ArrayBuffer during utf8Slice index coercion and verifies the operation fails safely instead of using stale memory.
Tests:
Closes denoland/divybot#441