fix(doc): handle non-ASCII doc lint diagnostics#34626
Merged
Merged
Conversation
Render documentation lint highlights using UTF-8 character boundaries so non-ASCII identifiers do not produce invalid diagnostic ranges. Co-Authored-By: Divy Srivastava <[email protected]>
littledivy
force-pushed
the
orch/divybot-366
branch
from
May 31, 2026 14:17
8db60bd to
657ff03
Compare
littledivy
approved these changes
May 31, 2026
littledivy
added a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
## Summary - render doc lint diagnostic highlights using UTF-8 character boundaries - cover non-ASCII exported symbols and private type references in doc lint specs ## Testing - cargo fmt --check - git diff --check - cargo check -p deno --bin deno Note: attempted to run the focused `deno doc --lint` fixture, but building a runnable binary required a separate full codegen pass; the type check completed successfully. Closes denoland/divybot#366 Co-authored-by: divybot <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note: attempted to run the focused
deno doc --lintfixture, but building a runnable binary required a separate full codegen pass; the type check completed successfully.Closes denoland/divybot#366