fix(node): expose gc from v8 setFlagsFromString#34604
Merged
Merged
Conversation
Co-Authored-By: Divy Srivastava <[email protected]>
Co-Authored-By: Divy Srivastava <[email protected]>
Co-Authored-By: Divy Srivastava <[email protected]>
Co-Authored-By: Divy Srivastava <[email protected]>
Co-Authored-By: Divy Srivastava <[email protected]>
Co-Authored-By: Divy Srivastava <[email protected]>
littledivy
added a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
## Summary
- implement node:v8 setFlagsFromString handling for
--expose_gc/--expose-gc
- expose a callable gc function in new node:vm contexts after the flag
is set
- add a unit-node regression test for runInNewContext('gc')
Fixes denoland#30317
Closes denoland/divybot#348
## Validation
- cargo fmt --check
- cargo check -p deno_node
- cargo build --bin deno
- ./target/debug/deno eval "import { setFlagsFromString } from
'node:v8'; import { runInNewContext } from 'node:vm'; console.log(typeof
globalThis.gc); setFlagsFromString('--expose_gc'); const gc =
runInNewContext('gc'); console.log(typeof gc); console.log(gc());"
Note: attempted cargo test -p unit_node_tests --test unit_node --
v8_test, but this local checkout fails before executing the test because
tests/util/std/assert/mod.ts is missing from the test fixture path.
---------
Co-authored-by: divybot <[email protected]>
Co-authored-by: Divy Srivastava <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30317
Closes denoland/divybot#348
Validation
Note: attempted cargo test -p unit_node_tests --test unit_node -- v8_test, but this local checkout fails before executing the test because tests/util/std/assert/mod.ts is missing from the test fixture path.