fix(ext/node): add node:test/reporters builtin#34595
Merged
Merged
Conversation
littledivy
force-pushed
the
orch/divybot-343
branch
2 times, most recently
from
May 31, 2026 03:38
d6a105a to
2833ffa
Compare
littledivy
reviewed
May 31, 2026
littledivy
left a comment
littledivy
left a comment
Member
There was a problem hiding this comment.
We have tap reporter stuff in node:test. Dedup?
Co-Authored-By: Divy Srivastava <[email protected]>
littledivy
force-pushed
the
orch/divybot-343
branch
from
May 31, 2026 04:29
2833ffa to
f9f68a0
Compare
littledivy
changed the title
littledivy
enabled auto-merge (squash)
May 31, 2026 05:15
littledivy
added a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
Adds the missing `node:test/reporters` builtin module and wires it through ESM, CommonJS, and the node resolver built-in allowlist. The module exports the documented built-in reporters (`tap`, `dot`, `junit`, `spec`, and `lcov`) and includes a regression spec for `node:test/reporters` resolution and TAP output. Closes denoland/orchid#343 Fixes denoland#31206 Validation: - `CARGO_INCREMENTAL=0 cargo build --bin deno --bin test_server` - `./target/debug/deno run tests/specs/node/node_test_reporters/main.mjs` - `cargo test -p specs_tests --test specs -- node_test_reporters --no-capture` - `cargo test -p node_resolver test_builtins_are_sorted` - `cargo fmt --check` - `./target/debug/deno fmt --check ext/node/polyfills/test/reporters.ts ext/node/polyfills/test/reporters_esm.ts tests/specs/node/node_test_reporters/main.mjs tests/specs/node/node_test_reporters/__test__.jsonc` Co-authored-by: divybot <[email protected]> Co-authored-by: Divy Srivastava <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing
node:test/reportersbuiltin module and wires it through ESM, CommonJS, and the node resolver built-in allowlist.The module exports the documented built-in reporters (
tap,dot,junit,spec, andlcov) and includes a regression spec fornode:test/reportersresolution and TAP output.Closes denoland/divybot#343
Fixes #31206
Validation:
CARGO_INCREMENTAL=0 cargo build --bin deno --bin test_server./target/debug/deno run tests/specs/node/node_test_reporters/main.mjscargo test -p specs_tests --test specs -- node_test_reporters --no-capturecargo test -p node_resolver test_builtins_are_sortedcargo fmt --check./target/debug/deno fmt --check ext/node/polyfills/test/reporters.ts ext/node/polyfills/test/reporters_esm.ts tests/specs/node/node_test_reporters/main.mjs tests/specs/node/node_test_reporters/__test__.jsonc