feat: stabilize text imports#34238
Merged
Merged
Conversation
bartlomieju
reviewed
May 19, 2026
| locker: locker.as_mut().map(|l| l as _), | ||
| unstable_bytes_imports: self.cli_options.unstable_raw_imports(), | ||
| unstable_text_imports: self.cli_options.unstable_raw_imports(), | ||
| unstable_text_imports: true, |
Member
There was a problem hiding this comment.
Can you open a PR to deno_graph yo remove this setting?
bartlomieju
reviewed
May 19, 2026
bartlomieju
left a comment
bartlomieju
left a comment
Member
There was a problem hiding this comment.
Maybe update some tests to not use the flag?
fibibot
previously requested changes
May 19, 2026
fibibot
left a comment
fibibot
left a comment
Contributor
There was a problem hiding this comment.
This needs a direct regression test for the stabilized behavior. The PR updates the missing-unstable dynamic case from text to bytes, which preserves the negative coverage for bytes, but I don't see a positive spec that runs with { type: "text" } without --unstable-raw-imports. Most existing text import specs still opt into raw-imports, so CI can pass without proving the stable path works for static and/or dynamic text imports.
Please update one of the existing text-import specs to drop the unstable flag, or add a focused spec that imports text without --unstable-raw-imports.
- Add tests/specs/run/bytes_and_text_imports/stable_text spec that exercises static and dynamic text imports without --unstable-raw-imports, proving the stabilized path works. - cli/tools/doc.rs: set unstable_text_imports to true for the builtin types graph for consistency with cli/graph_util.rs.
Contributor
|
Pushed a fix addressing the review:
|
bartlomieju
approved these changes
May 20, 2026
crowlKats
added a commit
to crowlKats/deno
that referenced
this pull request
Jun 2, 2026
Text imports were stabilized in denoland#34238, but `deno publish` still rejected `with { type: "text" }` imports as `unstable-raw-import` because the publish diagnostic flagged any asset import (both text and bytes). Only bytes imports remain unstable, so the diagnostic now only flags `type: "bytes"` imports. Closes denoland#34389
littledivy
pushed a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
This stabilizes `text` imports, so that:
```ts
import hello from "./hello.txt" with { type: "text" };
```
will not require the `--unstable-raw-imports` flag.
This is as the tc39 proposal is stage 3, and the html spec changes
required are already landed.
---------
Co-authored-by: crowlbot <[email protected]>
This was referenced Jun 26, 2026
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stabilizes
textimports, so that:will not require the
--unstable-raw-importsflag.This is as the tc39 proposal is stage 3, and the html spec changes required are already landed.