Skip to content

upgrade: Tokio 0.2#3418

Merged
bartlomieju merged 39 commits into
denoland:masterfrom
bartlomieju:upgrade-tokio_02
Dec 30, 2019
Merged

upgrade: Tokio 0.2#3418
bartlomieju merged 39 commits into
denoland:masterfrom
bartlomieju:upgrade-tokio_02

Conversation

@bartlomieju

@bartlomieju bartlomieju commented Nov 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

This PR upgrades Tokio version in CLI.

There are currently two pending issues:

  • new tokio::fs::File doesn't expose .into_std() method, which means file cannot be passed to subprocess as stdio (fixed in Tokio 0.2.2)
  • awaiting reqwest update, ie. fetch API doesn't work yet

Ref #3387, tokio-rs/tokio#1852

bartlomieju
bartlomieju commented Nov 28, 2019
View reviewed changes
Comment thread cli/Cargo.toml Outdated
@bartlomieju bartlomieju mentioned this pull request Nov 28, 2019
Closed
@bartlomieju

bartlomieju commented Dec 16, 2019

Copy link
Copy Markdown
Member Author

FYI: I hit some problems upgrading reqwest due to API changes there (Decoder which we use to implement HttpBody resource is no longer available). Anyway, still waiting on reqwest release, I'll coordinate with them to make this work.

@bartlomieju bartlomieju mentioned this pull request Dec 24, 2019
Closed
@bartlomieju
bartlomieju requested a review from ry December 27, 2019 19:01
@bartlomieju

bartlomieju commented Dec 28, 2019

Copy link
Copy Markdown
Member Author

reqwest is close to 0.10.0 release

95th
95th reviewed Dec 29, 2019
View reviewed changes
Comment thread cli/http_util.rs
This was referenced Dec 30, 2019
Closed
Merged
ry
ry approved these changes Dec 30, 2019
View reviewed changes

@ry ry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this! Please add TODOs and/or an issue describing the flush situation. It's not ideal - but I think we all agree that this needs to land. Otherwise LGTM.

This was referenced Dec 30, 2019
Closed
Closed
@bartlomieju
bartlomieju merged commit 46d76a7 into denoland:master Dec 30, 2019
@bartlomieju
bartlomieju deleted the upgrade-tokio_02 branch December 30, 2019 13:57
@95th

95th commented Jan 1, 2020

Copy link
Copy Markdown
Contributor

This PR has reduced the no. of syscalls
Annotation 2020-01-01 202239

There is also increase of one thread (Perhaps this is temporary due to uses of block_on at various places).
Annotation 2020-01-01 202239 2

@bartlomieju bartlomieju mentioned this pull request Jan 2, 2020
Closed
@hayd

hayd commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

Did this add native-tls as a requirement (in hyper?). It seems like openssl is now required (at least to build) on Amazon Linux, where previously we were using rustls?
https://github.com/hayd/deno-docker/runs/371640720

In the docs: https://hyper.rs/guides/client/configuration/

This means that you could pick a different TLS implementation than the one chosen by hyper-tls, such as rustls.

But I'm not really sure how!

caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@bartlomieju
upgrade: Tokio 0.2 (denoland/deno#3418)
529102d
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@bartlomieju
upgrade: Tokio 0.2 (denoland/deno#3418)
054d1ee
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@bartlomieju @caspervonb
upgrade: Tokio 0.2 (denoland/deno#3418)
1c09f8e
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@bartlomieju @caspervonb
upgrade: Tokio 0.2 (denoland/deno#3418)
d82a1a5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@bartlomieju @caspervonb
upgrade: Tokio 0.2 (denoland/deno#3418)
ce61932
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@bartlomieju @caspervonb
upgrade: Tokio 0.2 (denoland/deno#3418)
f69dfc5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@bartlomieju @caspervonb
upgrade: Tokio 0.2 (denoland/deno#3418)
54f5e84
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@bartlomieju @denobot
upgrade: Tokio 0.2 (denoland/deno#3418)
20a1e3f
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@bartlomieju @denobot
upgrade: Tokio 0.2 (denoland/deno#3418)
3c052e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ry ry ry approved these changes
+1 more reviewer
@95th 95th 95th left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bartlomieju @95th @hayd @ry