fix(ext/node): TLSSocket.setServername throws typed errors#33744
Merged
Conversation
`TLSSocket.prototype.setServername` threw plain `TypeError`/`Error` without the `code` property that Node attaches. Replace with the existing `ERR_INVALID_ARG_TYPE` and `ERR_TLS_SNI_FROM_SERVER` Node- compat error classes (the latter was already defined in `internal/errors.ts`, just not used here). Fixes denoland#33743.
1 task
bartlomieju
approved these changes
May 3, 2026
littledivy
pushed a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
…33744) `TLSSocket.prototype.setServername` in `ext/node/polyfills/_tls_wrap.js` threw plain `TypeError`/`Error` without the `code` property that Node.js attaches. User code and Node test suites that branch on `err.code` couldn't distinguish these errors. Replace with the existing `ERR_INVALID_ARG_TYPE` and `ERR_TLS_SNI_FROM_SERVER` Node-compat error classes from `internal/errors.ts` (the latter was already defined there but unused). Closes denoland#33743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TLSSocket.prototype.setServernameinext/node/polyfills/_tls_wrap.jsthrew plainTypeError/Errorwithout thecodeproperty that Node.js attaches. User code and Node test suites that branch onerr.codecouldn't distinguish these errors.Replace with the existing
ERR_INVALID_ARG_TYPEandERR_TLS_SNI_FROM_SERVERNode-compat error classes frominternal/errors.ts(the latter was already defined there but unused).Closes #33743.
Test plan
TLSSocket.setServername - throws ERR_INVALID_ARG_TYPE for non-stringtest intests/unit_node/tls_test.tsassertserr.name === "TypeError"anderr.code === "ERR_INVALID_ARG_TYPE"TLSSocket.setServername - throws ERR_TLS_SNI_FROM_SERVER on server-side sockettest assertserr.code === "ERR_TLS_SNI_FROM_SERVER"