perf(ext/node): elide async_hooks emit in timers when no hooks registered#33355
Merged
Conversation
…ered Match node: the Timeout ctor's emitInit and the per-fire emitBefore/emitAfter/emitDestroy calls only matter when async_hooks are active, but the machinery (try/finally, empty-array loop, lookupPublicResource) runs regardless. Gate all of them on enabledHooksExist(). Also drop ObjectDefineProperty for the _timer slot — direct assignment is fine and this runs per setTimeout on keep-alive HTTP connections.
bartlomieju
approved these changes
Apr 22, 2026
bartlomieju
left a comment
bartlomieju
left a comment
Member
There was a problem hiding this comment.
Nice, simple and significant win
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match node: the Timeout ctor's emitInit and the per-fire emitBefore/emitAfter/emitDestroy calls only matter when async_hooks are active, but the machinery (try/finally, empty-array loop, lookupPublicResource) runs regardless. Gate all of them on enabledHooksExist().
increases throughput by about 4.5% on hello world
Disclosure: used claude