feature: allow reading into a 0-length array#3329
Merged
Merged
Conversation
Fix #3287. Mimic POSIX read() behaviour: if there is no bytes to read, return 0 and do nothing. Document the new behaviour.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3287
The Deno read* functions can now return 0 if the supplied buffer has no size. This doesn’t change the previous behaviour, it just adds a new return value.
I wrote one test in
readNullBufferFailurein /cli/js/files_test.ts, but if you think it is useless or in the wrong function you can drop the second commit.