Repository navigation
fix(ext/node): preserve TLS upgrade state on reconnect - #32838
Conversation
ae03ecc to
703abbe
Compare
|
I’ve already signed the CLA. It looks like the remaining checks are still waiting for workflow approval before they can report back. Could a maintainer approve the workflow run when convenient? |
68e9934 to
a3d05ed
Compare
|
Hey @bartlomieju ,I just pushed the fixes for the previous CI errors. The workflow needs re-approval due to the force-push. Mind approving it again when convenient? Thanks! |
a3d05ed to
8054f65
Compare
8054f65 to
beca16e
Compare
|
Hey @bartlomieju, I pushed a follow-up fix for the Windows HTTP/2 callback type mismatch that was failing CI. This update switches the affected nghttp2 callback/data provider usage to the Locally I re-ran:
Could someone re-approve/re-run CI on the latest commit when convenient? Thanks! |
Thanks for the review and for merging this! |
Summary
net.Socketreinitializes its handle during reconnect fallbackkReinitializeHandlepreserving TLS upgrade stateTesting
deno fmt ext/node/polyfills/_tls_wrap.js ext/node/polyfills/net.ts tests/unit_node/tls_test.tscargo test -p unit_node_tests --test unit_node tls_test -- --nocapture