fix(ext/node): map ERROR_INVALID_NAME to ENOENT on windows#26475
Merged
kt3k merged 1 commit intodenoland:mainfrom Oct 23, 2024
Merged
fix(ext/node): map ERROR_INVALID_NAME to ENOENT on windows#26475kt3k merged 1 commit intodenoland:mainfrom
ERROR_INVALID_NAME to ENOENT on windows#26475kt3k merged 1 commit intodenoland:mainfrom
Conversation
bartlomieju
approved these changes
Oct 22, 2024
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, thanks for tracking this down!
bartlomieju
pushed a commit
that referenced
this pull request
Oct 25, 2024
In libuv on windows, `ERROR_INVALID_NAME` is mapped to `ENOENT`, but it is mapped to `EINVAL` in our compat implementation, which causes the issue #24899. ref: https://github.com/libuv/libuv/blob/d4ab6fbba4669935a6bc23645372dfe4ac29ab39/src/win/error.c#L138 closes #24899 closes #26411 closes #23635 closes #21165 closes #19067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In libuv on windows,
ERROR_INVALID_NAMEis mapped toENOENT, but it is mapped toEINVALin our compat implementation, which causes the issue #24899.ref: https://github.com/libuv/libuv/blob/d4ab6fbba4669935a6bc23645372dfe4ac29ab39/src/win/error.c#L138
This PR fixes the above.
closes #24899
closes #26411
closes #23635
closes #21165
closes #19067