fix: 'Promise was collected' error in REPL/jupyter#21272
Merged
bartlomieju merged 6 commits intodenoland:mainfrom Nov 22, 2023
Merged
fix: 'Promise was collected' error in REPL/jupyter#21272bartlomieju merged 6 commits intodenoland:mainfrom
bartlomieju merged 6 commits intodenoland:mainfrom
Conversation
bartlomieju
commented
Nov 20, 2023
Comment on lines
+305
to
+308
| // NOTE(bartlomieju): this is an important bit; we don't want to pump V8 | ||
| // message loop here, so that GC won't run. Otherwise, the resulting | ||
| // object might be GC'ed before we have a chance to inspect it. | ||
| pump_v8_message_loop: false, |
Contributor
There was a problem hiding this comment.
Wow. Thanks for noting it so heavily here.
mmastrac
approved these changes
Nov 22, 2023
Contributor
mmastrac
left a comment
mmastrac
left a comment
There was a problem hiding this comment.
LGTM assuming test passes!
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
crowlKats
pushed a commit
that referenced
this pull request
Nov 24, 2023
bartlomieju
added a commit
that referenced
this pull request
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20528