Skip to content

docs(README.md): fix typo#2

Merged
ry merged 1 commit into
denoland:masterfrom
kt3k:patch-1
May 29, 2018
Merged

docs(README.md): fix typo#2
ry merged 1 commit into
denoland:masterfrom
kt3k:patch-1

Conversation

@kt3k

@kt3k kt3k commented May 29, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@ry ry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ry
ry merged commit f72655c into denoland:master May 29, 2018
@kt3k
kt3k deleted the patch-1 branch May 29, 2018 09:36
ry referenced this pull request in ry/deno Sep 2, 2018
ry referenced this pull request in ry/deno Nov 3, 2018
ry referenced this pull request in ry/deno Dec 18, 2018
@ry ry mentioned this pull request Jun 5, 2020
yonbav added a commit to yonbav/deno that referenced this pull request Jan 22, 2021
- Remove ByteLength from base32 API
- Describe the difference between decode/encode and parse/stringify
- Remove utf8 file
dsherret referenced this pull request in dsherret/deno Jun 26, 2021
piscisaureus added a commit that referenced this pull request Oct 25, 2021
piscisaureus added a commit that referenced this pull request Oct 25, 2021
piscisaureus added a commit that referenced this pull request Oct 26, 2021
piscisaureus added a commit that referenced this pull request Oct 26, 2021
bartlomieju added a commit that referenced this pull request Feb 21, 2023
Instead of relying on "serde_v8" which is very inefficient in
serializing enums, I'm hand rolling serde for "ModuleMap" data 
that is stored in the V8 snapshot to make ES modules 
snapshottable.

```
// this branch
Benchmark #2: ./target/release/deno run empty.js

  Time (mean ± σ):      21.4 ms ±   0.9 ms    [User: 15.6 ms, System: 6.4 ms]

  Range (min … max):    20.2 ms …  24.4 ms

// main branch
Benchmark #2: ./target/release/deno run empty.js

  Time (mean ± σ):      23.1 ms ±   1.2 ms    [User: 17.0 ms, System: 6.2 ms]

  Range (min … max):    21.0 ms …  26.0 ms

```
willnewby pushed a commit that referenced this pull request Apr 19, 2023
bartlomieju added a commit that referenced this pull request Jul 7, 2025
#30019)

…9515)"

This reverts commit 248d038.

Reverting for now as it causes programs to not exit properly, see
#29590.

While we are working on a proper fix it's better to revert it
and not flush OTEL data in some situations.
This was referenced May 14, 2026
nathanwhit added a commit that referenced this pull request Jun 11, 2026
## Summary

This reduces startup snapshot deserialization overhead from native
callback function shapes.

The stack does three things:

- creates native accessor callbacks with `ConstructorBehavior::Throw`,
avoiding useless accessor `.prototype` graphs
- uses direct V8 functions for snapshotted top-level ops instead of
FunctionTemplates by default
- adds an explicit `#[op2(constructable)]` opt-in for top-level ops that
must preserve a public JS function prototype/constructor shape

## Snapshot Size

Measured with debug builds:

```sh
deno run --v8-flags=--profile-deserialization empty.js
```

Summing the three `Deserializing ... (N bytes)` rows, excluding the
final `Serializing to ...` row:

| build | total deserialized bytes | delta |
| --- | ---: | ---: |
| `main@upstream` | 4,768,928 | - |
| this PR | 4,466,352 | -302,576 bytes |

That is a 6.34% reduction in the deserialized snapshot byte total for
this measurement.

Breakdown:

| section | `main@upstream` | this PR | delta |
| --- | ---: | ---: | ---: |
| read-only space | 991,144 | 991,144 | 0 |
| isolate | 2,561,136 | 2,518,976 | -42,160 |
| context #2 | 1,216,648 | 956,232 | -260,416 |

Saved local binaries used for the comparison:

- `/tmp/deno-accessor-snapshot-binaries/deno-baseline-main-upstream`
-
`/tmp/deno-accessor-snapshot-binaries/deno-current-constructable-stack`

## Validation

```sh
cargo test -p deno_core_testing resource_test
cargo test -p deno_ops op2::tests
cargo check -p deno_core -p deno_core_testing -p deno_ops
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants