docs(README.md): fix typo#2
Merged
Merged
Conversation
yonbav
added a commit
to yonbav/deno
that referenced
this pull request
Jan 22, 2021
- Remove ByteLength from base32 API - Describe the difference between decode/encode and parse/stringify - Remove utf8 file
piscisaureus
added a commit
that referenced
this pull request
Oct 25, 2021
piscisaureus
added a commit
that referenced
this pull request
Oct 25, 2021
piscisaureus
added a commit
that referenced
this pull request
Oct 26, 2021
piscisaureus
added a commit
that referenced
this pull request
Oct 26, 2021
bartlomieju
added a commit
that referenced
this pull request
Feb 21, 2023
Instead of relying on "serde_v8" which is very inefficient in serializing enums, I'm hand rolling serde for "ModuleMap" data that is stored in the V8 snapshot to make ES modules snapshottable. ``` // this branch Benchmark #2: ./target/release/deno run empty.js Time (mean ± σ): 21.4 ms ± 0.9 ms [User: 15.6 ms, System: 6.4 ms] Range (min … max): 20.2 ms … 24.4 ms // main branch Benchmark #2: ./target/release/deno run empty.js Time (mean ± σ): 23.1 ms ± 1.2 ms [User: 17.0 ms, System: 6.2 ms] Range (min … max): 21.0 ms … 26.0 ms ```
4 tasks
This was referenced May 1, 2026
Merged
10 tasks
1 task
1 task
This was referenced May 14, 2026
Closed
This was referenced Jun 6, 2026
nathanwhit
added a commit
that referenced
this pull request
Jun 11, 2026
## Summary This reduces startup snapshot deserialization overhead from native callback function shapes. The stack does three things: - creates native accessor callbacks with `ConstructorBehavior::Throw`, avoiding useless accessor `.prototype` graphs - uses direct V8 functions for snapshotted top-level ops instead of FunctionTemplates by default - adds an explicit `#[op2(constructable)]` opt-in for top-level ops that must preserve a public JS function prototype/constructor shape ## Snapshot Size Measured with debug builds: ```sh deno run --v8-flags=--profile-deserialization empty.js ``` Summing the three `Deserializing ... (N bytes)` rows, excluding the final `Serializing to ...` row: | build | total deserialized bytes | delta | | --- | ---: | ---: | | `main@upstream` | 4,768,928 | - | | this PR | 4,466,352 | -302,576 bytes | That is a 6.34% reduction in the deserialized snapshot byte total for this measurement. Breakdown: | section | `main@upstream` | this PR | delta | | --- | ---: | ---: | ---: | | read-only space | 991,144 | 991,144 | 0 | | isolate | 2,561,136 | 2,518,976 | -42,160 | | context #2 | 1,216,648 | 956,232 | -260,416 | Saved local binaries used for the comparison: - `/tmp/deno-accessor-snapshot-binaries/deno-baseline-main-upstream` - `/tmp/deno-accessor-snapshot-binaries/deno-current-constructable-stack` ## Validation ```sh cargo test -p deno_core_testing resource_test cargo test -p deno_ops op2::tests cargo check -p deno_core -p deno_core_testing -p deno_ops ```
This was referenced Jun 15, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.