Skip to content

Comments

feat: ReadableStream.from#19446

Merged
crowlKats merged 6 commits intodenoland:mainfrom
crowlKats:readablestream_from
Jul 2, 2023
Merged

feat: ReadableStream.from#19446
crowlKats merged 6 commits intodenoland:mainfrom
crowlKats:readablestream_from

Conversation

@crowlKats
Copy link
Member

@crowlKats crowlKats commented Jun 9, 2023

Closes #19417

@crowlKats
Copy link
Member Author

@petamoriken unsure how to handle the primordials iterator issue here

@petamoriken
Copy link
Contributor

@crowlKats Simply add // deno-lint-ignore prefer-primordials 🙇

If we use GeneratorFunction in Deno internal, we need to handle it appropriately such as GeneratorPrototypeNext, but in this case, it is a code to receive AsyncIterable from userland, so we should ignore it.

@bartlomieju bartlomieju added this to the 1.35 milestone Jun 11, 2023
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streams: support ReadableStream.from()

5 participants