Revert "fix(ext/flash): graceful server startup/shutdown with unsettl…#16839
Merged
bartlomieju merged 1 commit intodenoland:mainfrom Nov 27, 2022
Merged
Revert "fix(ext/flash): graceful server startup/shutdown with unsettl…#16839bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju merged 1 commit intodenoland:mainfrom
Conversation
…ed promises in mind (denoland#16616)" This reverts commit fd023cf.
littledivy
approved these changes
Nov 27, 2022
cjihrig
added a commit
to denoland/std
that referenced
this pull request
Nov 28, 2022
…2950) This reverts commit 5f5413d. This change was made in response to denoland/deno#16616. However, that change was reverted in denoland/deno#16839 due to it breaking Vite. Let's revert it here as well.
kt3k
pushed a commit
that referenced
this pull request
Dec 1, 2022
#16839) …ed promises in mind (#16616)" This reverts commit fd023cf. There are reports saying that Vite is often hanging in 1.28.2 and this is the only PR that changed something with HTTP server. I think we should hold off on trying to fix this and instead focus on #16787 CC @magurotuna
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed promises in mind (#16616)"
This reverts commit fd023cf.
There are reports saying that Vite is often hanging in 1.28.2 and this is
the only PR that changed something with HTTP server. I think we should
hold off on trying to fix this and instead focus on #16787
CC @magurotuna