fix(ext/fetch): no auth on cross origin redirect#16745
Closed
lucacasonato wants to merge 7 commits intodenoland:mainfrom
Closed
fix(ext/fetch): no auth on cross origin redirect#16745lucacasonato wants to merge 7 commits intodenoland:mainfrom
lucacasonato wants to merge 7 commits intodenoland:mainfrom
Conversation
lucacasonato
force-pushed
the
fetch_no_auth_cross_origin_redirect
branch
from
1e18caf to
cc513dc
Compare
4 tasks
aapoalas
approved these changes
Mar 25, 2023
Contributor
aapoalas
left a comment
aapoalas
left a comment
There was a problem hiding this comment.
Looks good to me and the spec change has been merged. I guess this would be good to go?
Contributor
|
FWIW, Node.js made this change recently. It did lead to some fallout among the user base but that's the price of security. |
Contributor
|
@lucacasonato should I move this one to the 1.38 milestone or do you think it can be merged by tomorrow? |
Signed-off-by: Aapo Alasuutari <[email protected]>
Member
|
closing this because it's old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec change: whatwg/fetch#1544
Still waiting for WPTs and upstream spec merge.