fix(serde_v8): serialize objects with numeric keys correctly #15946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Sep 19, 2022
Fixes: denoland#11502 Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
changed the title
RaisinTen
force-pushed
the
fix-core/parse-json-correctly
branch
from
d5c881c to
10f0cac
Compare
Member
|
Hey @RaisinTen sorry for slow response. I'm swamped with reviews needed for v1.26 release, so I'll come back to you PR next week. |
bartlomieju
approved these changes
Oct 2, 2022
Member
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
LGTM, thank you @RaisinTen nice work!
hardfist
pushed a commit
to hardfist/deno
that referenced
this pull request
Aug 7, 2024
…d#15946) Signed-off-by: Darshan Sen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11502
Signed-off-by: Darshan Sen [email protected]
cc @bnoordhuis @AaronO