Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deno-coverage-ignore comments #16626

Open
eliassjogreen opened this issue Nov 14, 2022 · 5 comments · May be fixed by #26590
Open

deno-coverage-ignore comments #16626

eliassjogreen opened this issue Nov 14, 2022 · 5 comments · May be fixed by #26590
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted) help wanted community help requested testing related to deno test and coverage

Comments

@eliassjogreen
Copy link
Contributor

It would be nice to have the deno-coverage-ignore and deno-coverage-ignore-file comments which would essentially act the same as all other deno-*-ignore comments but for ignoring a specified line, branch or file when collecting coverage.
@bartlomieju
Copy link
Member

I think it makes sense. PRs are welcome!

@bartlomieju bartlomieju added help wanted community help requested enhancement labels Nov 14, 2022
@lucacasonato lucacasonato added cli related to cli/ dir testing related to deno test and coverage labels Nov 24, 2022
@gofenix
Copy link
Contributor

gofenix commented Dec 18, 2022

Hello, Maybe I can try to implement it.

@bartlomieju
Copy link
Member

Hello, Maybe I can try to implement it.

Please do

@gofenix gofenix mentioned this issue Dec 20, 2022
Closed
@loynoir
Copy link

loynoir commented Mar 27, 2023 •
edited
Loading

@zhenfeng-zhu

Any news? 🥺

Maybe section pair is easier to implement?

https://github.com/bcoe/c8

/* c8 ignore start */
function dontMindMe() {
  // ...
}
/* c8 ignore stop */

@pskfyi pskfyi mentioned this issue Apr 26, 2023
Open
@JAS-lzn
Copy link

JAS-lzn commented Sep 7, 2023 •
edited
Loading

work on this seems abandoned, I'd like to try and help, but I'm unsure of where to get started.

@bartlomieju, any guidance on how this should be approached?

@cenfun cenfun mentioned this issue Apr 14, 2024
Open
@lambdalisue lambdalisue mentioned this issue May 27, 2024
Merged
@bartlomieju bartlomieju mentioned this issue Jun 25, 2024
Closed
@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) and removed enhancement labels Sep 20, 2024
@bcheidemann bcheidemann linked a pull request Oct 27, 2024 that will close this issue
Open
This was referenced Nov 4, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli related to cli/ dir feat new feature (which has been agreed to/accepted) help wanted community help requested testing related to deno test and coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(coverage): add coverage ignore comments bcheidemann/denoland-deno
6 participants
@gofenix @lucacasonato @bartlomieju @eliassjogreen @JAS-lzn @loynoir