Skip to content

Comments

Upgrade alpha70#429

Merged
glicht merged 14 commits intodemisto:masterfrom
sserrata:upgrade-alpha70
Feb 2, 2021
Merged

Upgrade alpha70#429
glicht merged 14 commits intodemisto:masterfrom
sserrata:upgrade-alpha70

Conversation

@sserrata
Copy link
Contributor

@sserrata sserrata commented Jan 4, 2021

Status

In Progress

Related Issues

fixes: link to the issue

Description

Upgrades to Docusaurus alpha 70.

Please note that this release checks for non-empty markdown link and image URLs. There were three reference docs flagged during my testing that contained empty image URLs:

  • /docs/reference/playbooks/get-file-sample-from-hash---generic.md
  • /docs.reference/playbooks/playbook1.md
  • /docs.reference/playbooks/playbook2.md

Not addressing empty markdown link or image URLs can result in the following error:

Error: Markdown image url is mandatory or Error: Markdown link url is mandatory

Screenshots

Paste here any images that will help the reviewer

@lgtm-com
Copy link

lgtm-com bot commented Jan 14, 2021

This pull request introduces 1 alert when merging 33e39e7 into d39ef7a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 1 alert when merging 75baeae into 01a3529 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 1 alert when merging f2e3404 into 01a3529 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

Preview Site Available

Congratulations! The automatic build has completed succesfully.
A preview site is available at: https://pull-request-429--demisto-content-docs.netlify.app


Important: Make sure to inspect your changes at the preview site.

1 similar comment
@github-actions
Copy link

Preview Site Available

Congratulations! The automatic build has completed succesfully.
A preview site is available at: https://pull-request-429--demisto-content-docs.netlify.app


Important: Make sure to inspect your changes at the preview site.

@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request introduces 1 alert when merging 679a52b into d893ab9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request introduces 1 alert when merging 30b3534 into d893ab9 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@github-actions
Copy link

Preview Site Available

Congratulations! The automatic build has completed succesfully.
A preview site is available at: https://pull-request-429--demisto-content-docs.netlify.app


Important: Make sure to inspect your changes at the preview site.

1 similar comment
@github-actions
Copy link

Preview Site Available

Congratulations! The automatic build has completed succesfully.
A preview site is available at: https://pull-request-429--demisto-content-docs.netlify.app


Important: Make sure to inspect your changes at the preview site.

@lgtm-com
Copy link

lgtm-com bot commented Feb 1, 2021

This pull request introduces 1 alert when merging 0d98b1e into 8bc9e8c - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sserrata
Copy link
Contributor Author

sserrata commented Feb 1, 2021

@glicht Can you assist with the most recent build error? It appears to be related to a missing python package.

Traceback (most recent call last):
  File "./gen_pydocs.py", line 8, in <module>
    import docspec
  File "/home/circleci/.local/share/virtualenvs/project-zxI9dQ-Q/lib/python3.8/site-packages/docspec/__init__.py", line 44, in <module>
    from nr.databind.json import JsonModule
ModuleNotFoundError: No module named 'nr.databind.json'

@glicht
Copy link
Contributor

glicht commented Feb 1, 2021

@glicht Can you assist with the most recent build error? It appears to be related to a missing python package.

Traceback (most recent call last):
  File "./gen_pydocs.py", line 8, in <module>
    import docspec
  File "/home/circleci/.local/share/virtualenvs/project-zxI9dQ-Q/lib/python3.8/site-packages/docspec/__init__.py", line 44, in <module>
    from nr.databind.json import JsonModule
ModuleNotFoundError: No module named 'nr.databind.json'

Will check. Started a re-build as a start. It might be some temporary install issue of python deps.

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

Preview Site Available

Congratulations! The automatic build has completed succesfully.
A preview site is available at: https://pull-request-429--demisto-content-docs.netlify.app


Important: Make sure to inspect your changes at the preview site.

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

Preview Site Available

Congratulations! The automatic build has completed succesfully.
A preview site is available at: https://pull-request-429--demisto-content-docs.netlify.app


Important: Make sure to inspect your changes at the preview site.

@glicht
Copy link
Contributor

glicht commented Feb 1, 2021

@sserrata re-build passed. Are you ok to merge?

@glicht
Copy link
Contributor

glicht commented Feb 1, 2021

@sserrata note that we got one new alert from lgtm. See: #429 (comment)

@sserrata
Copy link
Contributor Author

sserrata commented Feb 1, 2021

Everything looks good to me. I'm ready to merge.

@glicht glicht merged commit fc49611 into demisto:master Feb 2, 2021
@xsoar-bot
Copy link

Production Site Updated

Congratulations! The automatic build has completed succesfully.
The production site of our docs has been updated. You can view it at: https://xsoar.pan.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants