chore: sync Helm chart CRDs with controller-gen output#184
Merged
Conversation
The Helm chart CRD templates had drifted from the generated CRDs in config/crd/bases/. This syncs both Model and InferenceService CRDs to match the controller-gen output on main. Model CRD changes: - Add Arch printer column (.status.gguf.architecture) - Add entire gguf status sub-object (architecture, contextLength, embeddingSize, fileVersion, headCount, layerCount, modelName, quantization, tensorCount) - Update source field validation to accept absolute paths for air-gapped deployments InferenceService CRD changes: - Add jinja spec field for tool/function calling support - Update Toleration operator description for K8s 1.35 Signed-off-by: Christopher Maher <[email protected]> Signed-off-by: Christopher Maher <[email protected]>
CRD templates are auto-generated by controller-gen and contain description text like "context length (tokens)" which triggers a false positive in the hard-coded secrets check. Signed-off-by: Christopher Maher <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/crd/bases/Archprinter column, fullggufstatus sub-object, and air-gapped path validationjinjaspec field and updates Toleration description for K8s 1.35Context
The Helm chart CRD templates are manually maintained copies that had drifted from the controller-gen output across several PRs. This sync catches up all accumulated drift.
Test plan
helm templaterenders valid CRDsconfig/crd/bases/shows only the Helm template wrappers (crds.install/crds.keep)helm upgradeon a running cluster applies cleanly (additive schema changes only)