feat: introduce advancedHTTP for expose field & change podLabels to selector#154
Merged
jeff-mccoy merged 17 commits intomainfrom Feb 9, 2024
Merged
feat: introduce advancedHTTP for expose field & change podLabels to selector#154jeff-mccoy merged 17 commits intomainfrom
jeff-mccoy merged 17 commits intomainfrom
Conversation
jeff-mccoy
changed the title
chance-coleman
previously approved these changes
Feb 8, 2024
chance-coleman
dismissed
their stale review
I probably should wait to approve till CI works successfully
mjnagel
changed the title
This reverts commit bf762ee.
mjnagel
reviewed
Feb 8, 2024
Contributor
mjnagel
left a comment
mjnagel
left a comment
There was a problem hiding this comment.
Couple minor comments, overall good. Probably a good pattern we can set here for deprecating things and removal later on.
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
Co-authored-by: Micah Nagel <[email protected]>
mjnagel
previously approved these changes
Feb 9, 2024
Contributor
mjnagel
left a comment
mjnagel
left a comment
There was a problem hiding this comment.
I like the approach with the migrate fn. Might need to regen the CRD file(s) after those spelling changes to update the comments? LGTM overall.
mjnagel
approved these changes
Feb 9, 2024
jeff-mccoy
pushed a commit
that referenced
this pull request
Feb 9, 2024
🤖 I have created a release *beep* *boop* --- ## [0.12.0](v0.11.1...v0.12.0) (2024-02-09) ### Features * introduce advancedHTTP for expose field & change podLabels to selector ([#154](#154)) ([1079267](1079267)) ### Miscellaneous * **deps:** pin dependencies ([#79](#79)) ([bfab11e](bfab11e)) * remove retry-action action on registry1 docker login ([#160](#160)) ([eea0c93](eea0c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjnagel
added a commit
to BagelLab/uds-core
that referenced
this pull request
Nov 14, 2025
…elector (defenseunicorns#154) This PR deprecates `podLabels`, 'remotePodsLabels', and `match` and changes this to `selector`, `remoteSelector` and `advancedHTTP.match`, respectively. This PR also introduces `advancedHTTP` which brings support for the following `VirtualService` fields: - `corsPolicy` - `directResponse` - `headers` - `retries` - `rewrite` - `timeout` - `weight` --------- Co-authored-by: Micah Nagel <[email protected]> Co-authored-by: Micah Nagel <[email protected]>
mjnagel
pushed a commit
to BagelLab/uds-core
that referenced
this pull request
Nov 14, 2025
🤖 I have created a release *beep* *boop* --- ## [0.12.0](defenseunicorns/uds-core@v0.11.1...v0.12.0) (2024-02-09) ### Features * introduce advancedHTTP for expose field & change podLabels to selector ([defenseunicorns#154](defenseunicorns#154)) ([1079267](defenseunicorns@1079267)) ### Miscellaneous * **deps:** pin dependencies ([#79](defenseunicorns#79)) ([bfab11e](defenseunicorns@bfab11e)) * remove retry-action action on registry1 docker login ([defenseunicorns#160](defenseunicorns#160)) ([eea0c93](defenseunicorns@eea0c93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
podLabels, 'remotePodsLabels', andmatchand changes this toselector,remoteSelectorandadvancedHTTP.match, respectively. This PR also introducesadvancedHTTPwhich brings support for the followingVirtualServicefields:corsPolicydirectResponseheadersretriesrewritetimeoutweight