Skip to content

feat: new bundle variable - KEYCLOAK_HEAP_OPTIONS#1314

Merged
chance-coleman merged 7 commits intomainfrom
1309-switch-to-variable
Mar 3, 2025
Merged

feat: new bundle variable - KEYCLOAK_HEAP_OPTIONS#1314
chance-coleman merged 7 commits intomainfrom
1309-switch-to-variable

Conversation

@slaskawi
Copy link
Copy Markdown
Contributor

@slaskawi slaskawi commented Feb 24, 2025

Description

This Pull Request introduces KEYCLOAK_HEAP_OPTIONS to control the Java Heap
configuration passed into Keycloak deployments.

Related Issue

Relates to #1309

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

Run the CI and check the Keyclaok Pod Spec

Checklist before merging

@slaskawi slaskawi marked this pull request as ready for review February 25, 2025 08:01
@slaskawi slaskawi requested a review from a team as a code owner February 25, 2025 08:01
@slaskawi
Copy link
Copy Markdown
Contributor Author

slaskawi commented Feb 25, 2025

Checked the CI logs and the Keycloak Pod configuration seems to be correct:

        - name: JAVA_OPTS_KC_HEAP
          value: -XX:MaxRAMPercentage=70 -XX:MinRAMPercentage=70 -XX:InitialRAMPercentage=50
            -XX:MaxRAM=1G

mjnagel
mjnagel reviewed Feb 25, 2025
View reviewed changes
mjnagel
mjnagel approved these changes Mar 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we want to add a note anywhere to document the flag required for m4 macs?

@mjnagel
Copy link
Copy Markdown
Contributor

mjnagel commented Mar 3, 2025

@slaskawi going to merge this as-is but might be good for us to document the m4 flag as a follow on PR 😄

@chance-coleman chance-coleman enabled auto-merge (squash) March 3, 2025 20:11
@chance-coleman chance-coleman merged commit f7e0ebb into main Mar 3, 2025
16 checks passed
@chance-coleman chance-coleman deleted the 1309-switch-to-variable branch March 3, 2025 20:49
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
Merged
chance-coleman pushed a commit that referenced this pull request Mar 3, 2025
@github-actions
chore(main): release 0.37.0 (#1312)
4aac12e 
🤖 I have created a release *beep* *boop*
---


##
[0.37.0](v0.36.2...v0.37.0)
(2025-03-03)


### Features

* kstatus for Pepr
([#1288](#1288))
([c1b78d2](c1b78d2))
* new bundle variable - KEYCLOAK_HEAP_OPTIONS
([#1314](#1314))
([f7e0ebb](f7e0ebb))


### Miscellaneous

* **deps:** update grafana
([#1285](#1285))
([ffda059](ffda059))
* **deps:** update jest to v29.2.6
([#1313](#1313))
([d30c6c7](d30c6c7))
* **deps:** update keycloak to v26.1.3
([#1326](#1326))
([691eebe](691eebe))
* **deps:** update loki
([#1272](#1272))
([54b2cfc](54b2cfc))
* **deps:** update prometheus to 3.2.0, prometheus-operator to 0.80.1
([#1262](#1262))
([d1c6c3c](d1c6c3c))
* **deps:** update prometheus to v3.2.1
([#1321](#1321))
([e1ee576](e1ee576))
* **deps:** update support-deps
([#1289](#1289))
([73f5de2](73f5de2))
* **deps:** update support-deps
([#1323](#1323))
([2822097](2822097))
* **deps:** update vector to 0.45.0
([#1316](#1316))
([c66e807](c66e807))
* enable ambient component for rke2/aks ci
([#1322](#1322))
([c280b03](c280b03))
* switch to azure gov account
([#1318](#1318))
([31ec997](31ec997))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@slaskawi slaskawi mentioned this pull request Mar 5, 2025
Merged
5 tasks
slaskawi added a commit that referenced this pull request Mar 6, 2025
@slaskawi @chance-coleman
feat: document workaround for Keycloak and Apple M4 Macs (#1337)
ae51155 
## Description

This issue documents the workaround introduced in
#1314

## Related Issue

Relates to #1309

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

N/A

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: Chance <[email protected]>
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@slaskawi @chance-coleman @mjnagel
feat: new bundle variable - KEYCLOAK_HEAP_OPTIONS (defenseunicorns#1314)
84cc8bb 
## Description

This Pull Request introduces `KEYCLOAK_HEAP_OPTIONS` to control the Java
Heap
configuration passed into Keycloak deployments.

## Related Issue

Relates to defenseunicorns#1309

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate

Run the CI and check the Keyclaok Pod Spec

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: Chance <[email protected]>
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@github-actions @mjnagel
chore(main): release 0.37.0 (defenseunicorns#1312)
cb274ec 
🤖 I have created a release *beep* *boop*
---


##
[0.37.0](defenseunicorns/uds-core@v0.36.2...v0.37.0)
(2025-03-03)


### Features

* kstatus for Pepr
([defenseunicorns#1288](defenseunicorns#1288))
([c1b78d2](defenseunicorns@c1b78d2))
* new bundle variable - KEYCLOAK_HEAP_OPTIONS
([defenseunicorns#1314](defenseunicorns#1314))
([f7e0ebb](defenseunicorns@f7e0ebb))


### Miscellaneous

* **deps:** update grafana
([defenseunicorns#1285](defenseunicorns#1285))
([ffda059](defenseunicorns@ffda059))
* **deps:** update jest to v29.2.6
([defenseunicorns#1313](defenseunicorns#1313))
([d30c6c7](defenseunicorns@d30c6c7))
* **deps:** update keycloak to v26.1.3
([defenseunicorns#1326](defenseunicorns#1326))
([691eebe](defenseunicorns@691eebe))
* **deps:** update loki
([defenseunicorns#1272](defenseunicorns#1272))
([54b2cfc](defenseunicorns@54b2cfc))
* **deps:** update prometheus to 3.2.0, prometheus-operator to 0.80.1
([defenseunicorns#1262](defenseunicorns#1262))
([d1c6c3c](defenseunicorns@d1c6c3c))
* **deps:** update prometheus to v3.2.1
([defenseunicorns#1321](defenseunicorns#1321))
([e1ee576](defenseunicorns@e1ee576))
* **deps:** update support-deps
([defenseunicorns#1289](defenseunicorns#1289))
([73f5de2](defenseunicorns@73f5de2))
* **deps:** update support-deps
([defenseunicorns#1323](defenseunicorns#1323))
([2822097](defenseunicorns@2822097))
* **deps:** update vector to 0.45.0
([defenseunicorns#1316](defenseunicorns#1316))
([c66e807](defenseunicorns@c66e807))
* enable ambient component for rke2/aks ci
([defenseunicorns#1322](defenseunicorns#1322))
([c280b03](defenseunicorns@c280b03))
* switch to azure gov account
([defenseunicorns#1318](defenseunicorns#1318))
([31ec997](defenseunicorns@31ec997))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@slaskawi @chance-coleman @mjnagel
feat: document workaround for Keycloak and Apple M4 Macs (defenseunic…
cb4f00d 
…orns#1337)

## Description

This issue documents the workaround introduced in
defenseunicorns#1314

## Related Issue

Relates to defenseunicorns#1309

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Steps to Validate

N/A

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: Chance <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjnagel mjnagel mjnagel approved these changes

+1 more reviewer

@bhearn7 bhearn7 bhearn7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slaskawi @mjnagel @bhearn7 @chance-coleman