Skip to content

feat: kstatus for Pepr#1288

Merged
slaskawi merged 16 commits intomainfrom
991-status_conditions_pepr
Feb 22, 2025
Merged

feat: kstatus for Pepr#1288
slaskawi merged 16 commits intomainfrom
991-status_conditions_pepr

Conversation

@slaskawi
Copy link
Copy Markdown
Contributor

@slaskawi slaskawi commented Feb 15, 2025 •
edited
Loading

Description

This Pull Request introduces kstatus to the Pepr Operator. At the moment it supports setting only one condition:

 status:
   phase: Ready
   conditions:
    - lastTransitionTime: "2025-02-17T09:33:00.748Z"
      message: The package is ready for use.
      reason: ReconciliationComplete
      status: "True"
      type: Ready

Related Issue

Fixes #991

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

Run UDS Core with this patch on and observe kubectl get packages -o yaml --all-namespaces.

Checklist before merging

@slaskawi slaskawi force-pushed the 991-status_conditions_pepr branch from 4c0edee to b06df20 Compare February 17, 2025 08:21
@slaskawi slaskawi changed the title [WIP] kstatus for Pepr feat: kstatus for Pepr Feb 17, 2025
@slaskawi slaskawi marked this pull request as ready for review February 17, 2025 08:33
@slaskawi slaskawi requested a review from a team as a code owner February 17, 2025 08:33
slaskawi
slaskawi commented Feb 17, 2025
View reviewed changes
slaskawi
slaskawi commented Feb 17, 2025
View reviewed changes
slaskawi
slaskawi commented Feb 17, 2025
View reviewed changes
slaskawi
slaskawi commented Feb 17, 2025
View reviewed changes
mjnagel
mjnagel reviewed Feb 18, 2025
View reviewed changes
mjnagel
mjnagel reviewed Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty great otherwise - maintains our old custom status as well as adding the kstatus conditions! I'll validate a deploy locally as well just to confirm.

We don't have to do this in this PR but I'd be curious if could drop the onDeploy.after actions that we have in several of our src/ zarf packages. As mentioned in the original issue Zarf should honor the kstatus of these CRDs now so that we can delete those 😄

@slaskawi slaskawi mentioned this pull request Feb 20, 2025
Closed
5 tasks
@slaskawi
Copy link
Copy Markdown
Contributor Author

slaskawi commented Feb 20, 2025

@mjnagel Absolutely! The test results look very promising: #1307

chance-coleman
chance-coleman reviewed Feb 20, 2025
View reviewed changes
mjnagel
mjnagel reviewed Feb 21, 2025
View reviewed changes
mjnagel
mjnagel approved these changes Feb 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall @slaskawi - validated locally that it behaves as expected for both working and "broken" packages. Put one thread on the diff for consideration but I'm good with this PR as-is.

@slaskawi slaskawi enabled auto-merge (squash) February 22, 2025 11:09
@slaskawi slaskawi merged commit c1b78d2 into main Feb 22, 2025
33 checks passed
@slaskawi slaskawi deleted the 991-status_conditions_pepr branch February 22, 2025 11:09
@github-actions github-actions bot mentioned this pull request Feb 22, 2025
Merged
chance-coleman pushed a commit that referenced this pull request Mar 3, 2025
@github-actions
chore(main): release 0.37.0 (#1312)
4aac12e 
🤖 I have created a release *beep* *boop*
---


##
[0.37.0](v0.36.2...v0.37.0)
(2025-03-03)


### Features

* kstatus for Pepr
([#1288](#1288))
([c1b78d2](c1b78d2))
* new bundle variable - KEYCLOAK_HEAP_OPTIONS
([#1314](#1314))
([f7e0ebb](f7e0ebb))


### Miscellaneous

* **deps:** update grafana
([#1285](#1285))
([ffda059](ffda059))
* **deps:** update jest to v29.2.6
([#1313](#1313))
([d30c6c7](d30c6c7))
* **deps:** update keycloak to v26.1.3
([#1326](#1326))
([691eebe](691eebe))
* **deps:** update loki
([#1272](#1272))
([54b2cfc](54b2cfc))
* **deps:** update prometheus to 3.2.0, prometheus-operator to 0.80.1
([#1262](#1262))
([d1c6c3c](d1c6c3c))
* **deps:** update prometheus to v3.2.1
([#1321](#1321))
([e1ee576](e1ee576))
* **deps:** update support-deps
([#1289](#1289))
([73f5de2](73f5de2))
* **deps:** update support-deps
([#1323](#1323))
([2822097](2822097))
* **deps:** update vector to 0.45.0
([#1316](#1316))
([c66e807](c66e807))
* enable ambient component for rke2/aks ci
([#1322](#1322))
([c280b03](c280b03))
* switch to azure gov account
([#1318](#1318))
([31ec997](31ec997))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mjnagel mjnagel mentioned this pull request Mar 4, 2025
Merged
1 task
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@slaskawi @mjnagel
feat: kstatus for Pepr (defenseunicorns#1288)
b53f7b9 
## Description

This Pull Request introduces
[kstatus](https://github.com/kubernetes-sigs/cli-utils/blob/master/pkg/kstatus/README.md)
to the Pepr Operator. At the moment it supports setting only one
condition:

```yaml
 status:
   phase: Ready
   conditions:
    - lastTransitionTime: "2025-02-17T09:33:00.748Z"
      message: The package is ready for use.
      reason: ReconciliationComplete
      status: "True"
      type: Ready
```

## Related Issue

Fixes defenseunicorns#991

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Steps to Validate

Run UDS Core with this patch on and observe `kubectl get packages -o
yaml --all-namespaces`.

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor
Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)
followed
mjnagel pushed a commit to BagelLab/uds-core that referenced this pull request Nov 14, 2025
@github-actions @mjnagel
chore(main): release 0.37.0 (defenseunicorns#1312)
cb274ec 
🤖 I have created a release *beep* *boop*
---


##
[0.37.0](defenseunicorns/uds-core@v0.36.2...v0.37.0)
(2025-03-03)


### Features

* kstatus for Pepr
([defenseunicorns#1288](defenseunicorns#1288))
([c1b78d2](defenseunicorns@c1b78d2))
* new bundle variable - KEYCLOAK_HEAP_OPTIONS
([defenseunicorns#1314](defenseunicorns#1314))
([f7e0ebb](defenseunicorns@f7e0ebb))


### Miscellaneous

* **deps:** update grafana
([defenseunicorns#1285](defenseunicorns#1285))
([ffda059](defenseunicorns@ffda059))
* **deps:** update jest to v29.2.6
([defenseunicorns#1313](defenseunicorns#1313))
([d30c6c7](defenseunicorns@d30c6c7))
* **deps:** update keycloak to v26.1.3
([defenseunicorns#1326](defenseunicorns#1326))
([691eebe](defenseunicorns@691eebe))
* **deps:** update loki
([defenseunicorns#1272](defenseunicorns#1272))
([54b2cfc](defenseunicorns@54b2cfc))
* **deps:** update prometheus to 3.2.0, prometheus-operator to 0.80.1
([defenseunicorns#1262](defenseunicorns#1262))
([d1c6c3c](defenseunicorns@d1c6c3c))
* **deps:** update prometheus to v3.2.1
([defenseunicorns#1321](defenseunicorns#1321))
([e1ee576](defenseunicorns@e1ee576))
* **deps:** update support-deps
([defenseunicorns#1289](defenseunicorns#1289))
([73f5de2](defenseunicorns@73f5de2))
* **deps:** update support-deps
([defenseunicorns#1323](defenseunicorns#1323))
([2822097](defenseunicorns@2822097))
* **deps:** update vector to 0.45.0
([defenseunicorns#1316](defenseunicorns#1316))
([c66e807](defenseunicorns@c66e807))
* enable ambient component for rke2/aks ci
([defenseunicorns#1322](defenseunicorns#1322))
([c280b03](defenseunicorns@c280b03))
* switch to azure gov account
([defenseunicorns#1318](defenseunicorns#1318))
([31ec997](defenseunicorns@31ec997))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjnagel mjnagel mjnagel approved these changes

@chance-coleman chance-coleman chance-coleman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement .status.conditions on package.uds.dev to allow for evaluation with kstatus

3 participants

@slaskawi @mjnagel @chance-coleman