Repository navigation
Return empty list from entries() and free the overlap object - #167
Merged
Merged
Conversation
…s#149) The early return for a zero-entry overlap result returned Py_None, which is not iterable and also leaked the result structure. Return PyList_New(0) instead so entries() is safe to use directly in loops and comprehensions, matching values() which already returns [] on empty queries.
barlowa124
added a commit
to barlowa124/barlowa124
that referenced
this pull request
Oct 20, 2026
…un oncology ledger - Record newly merged upstream PRs: rdkit#9670, rdkit#9674, openmm#5487, deeptools/pyBigWig#167, sgkit-dev/sgkit#1353, hgrecco/pint#2474, and openmc-dev/openmc#4188 - Add ailm-inspectable to the Trustworthy ML and scientific agents table - Update oncology-coscientist summary with the 68-run ledger and 2x3 Qwen2.5-3B/14B sweep - Add .gitignore for local untracked notes Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #149.
BBFile.entries()returnedNonewhen a query overlaps nothing.Iterating that result raises TypeError, and the early return also
skipped
bbDestroyOverlappingEntries, leaking the overlap struct.values()in the same class already returns[]for emptyresults, and
testBigBedasserts that convention.entries()nowreturns
[]as well, and the overlap object is destroyed on theempty path.
testBigBedgains a case querying a region with no entries in thebundled
test.bigBed: it asserts[]and iterates the result.Populated regions still return tuples with the interval strings.
The test module passes locally.