Added sortUsingSamples and clusterUsingSamples to the galaxy wrapper #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Aug 10, 2020
galaxy/wrapper/plotHeatmap.xml
Outdated
| <when value="yes"> | ||
| <expand macro="sortRegions" /> | ||
| <expand macro="sortUsing" /> | ||
| <param argument="--sortUsingSamples" type="text" size="30" |
Member
There was a problem hiding this comment.
size can be removed it is not used anymore
Contributor
Author
There was a problem hiding this comment.
then I remove it from other options too
galaxy/wrapper/plotHeatmap.xml
Outdated
| <param argument="--sortUsingSamples" type="text" size="30" | ||
| label="List of samples to be used for sorting" | ||
| help="List of sample numbers (order as in matrix), which are used by --sortUsing for sorting. | ||
| If no value is set, it uses all samples. Example: 1 3 (space separated!)"> |
Member
There was a problem hiding this comment.
Can you please add:
<sanitizer invalid_char="">
<valid initial="string.digits">
<add value=" "/>
</valid>
</sanitizer>
This will make sure only digits and space and be entered.
galaxy/wrapper/plotHeatmap.xml
Outdated
| help="The default is to make one plot per bigWig file, i.e., all samples next to each other. Choosing this option will make one plot per group of regions."/> | ||
|
|
||
| <expand macro="kmeans_clustering" /> | ||
| <param argument="--clusterUsingSamples" type="text" size="30" |
galaxy/wrapper/plotHeatmap.xml
Outdated
| <param argument="--clusterUsingSamples" type="text" size="30" | ||
| label="List of samples to be used for clustering" | ||
| help="List of sample numbers (order as in matrix), which are used by --kmeans or --hclust for clustering. | ||
| If no value is set, it uses all samples. Example: 1 3 (space separated!)"> |
Contributor
Author
There was a problem hiding this comment.
@bgruening I have already changed them. Is it good now? If so, I am gonna merge it.
added 5 commits
August 10, 2020 16:30
… anitizer for the 2 new params.
Member
|
Yes, that looks great. Thanks @LeilyR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
Added sortUsingSamples and clusterUsingSamples to galaxy wrapper as has been asked in #976