changed itmesiter() in estimateEscaleFactor to its python3 compatible items() #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you grep through the code and see if iteritems() slipped in anywhere else? Thanks for fixing this :) |
Contributor
Author
|
that seemed to be the only one |
Collaborator
|
Great, do you want to bump the build number and then tag a new release once this is merged in or should I? Tagging a release automatically uploads a tarball to pypi, so you don't have to do any of that :) |
Contributor
Author
|
sure, since I have it open here on my machine I can quickly take care of the version number too. change the third digit only, right? |
Collaborator
|
Yes, please also change the version in the Galaxy wrapper and update the release notes to mention that this was fixed. |
Collaborator
|
BTW, you can ignore the last failure, that happens sometimes. |
Collaborator
|
Thanks! |
Contributor
Author
|
sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed itmesiter() in estimateEscaleFactor to its python3 compatible items(). This PR addresses #942 issue.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :