Np2 #1325
Merged
Np2 #1325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@bgruening Some planemo tests were failing so I upped the GALAXY_BRANCH in the tests to release_24.1 (so far so good!). What I'm not sure about is the GALAXY_VERSION under deepTools_macros.xml. Can we keep this at 22 or should this be boosted as well ? |
bgruening
approved these changes
Oct 4, 2024
Member
bgruening
left a comment
bgruening
left a comment
There was a problem hiding this comment.
This looks all great to me. Sorry was on a conference without internet ...
The GALAXY_VERSION is some kind of upper bound. Those tools need at leat this version ... So no need for a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
Does the PR contain new feature?
Does the PR contain bugfix?
Does the PR contain documentation changes?
Does the PR contain changes to the galaxy wrapper?
action versions boosted
conda env for actions removed
python 3.8 support dropped, numpy v2 is mininum now, np.NAN dropped (closes Typo/Bug in heatmapper.py script #1322)
planemo galaxy branched upped to 24.1