Skip to content

Do not use Tick.label #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WardDeb merged 2 commits into from
Sep 26, 2023
Merged

Do not use Tick.label #1258

WardDeb merged 2 commits into from
Sep 26, 2023

Conversation

@lldelisle
Copy link

@lldelisle lldelisle commented Sep 26, 2023

To support matplotlib 3.8.0:
https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.8.0.html#unused-methods-in-axis-tick-xaxis-and-yaxis

This was spotted by the galaxy tool:
https://github.com/deeptools/deepTools/actions/runs/6305763719/job/17120046090?pr=1257

Job in error state.. tool_id: deeptools_plot_correlation, exit_code: 1, stderr: Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/test_and_build/bin/plotCorrelation", line 8, in <module>
    sys.exit(main())
  File "/usr/share/miniconda3/envs/test_and_build/lib/python3.10/site-packages/deeptools/plotCorrelation.py", line 244, in main
    corr.plot_scatter(args.plotFile,
  File "/usr/share/miniconda3/envs/test_and_build/lib/python3.10/site-packages/deeptools/correlation.py", line 507, in plot_scatter
    tick.label.set_rotation(45)
AttributeError: 'XTick' object has no attribute 'label'. Did you mean: '_label'?
.

@lldelisle
Copy link
Author

lldelisle commented Sep 26, 2023

Relative to Matplotlib versions:
This commit: ce327bc
Broke compatibility with matplotlib prior to 3.5. I think it should be fixed or the pyproject should be updated.

@WardDeb WardDeb changed the base branch from master to develop September 26, 2023 15:26
@WardDeb
Copy link
Member

WardDeb commented Sep 26, 2023

Thanks @lldelisle this slipped under the radar, I'll make another PR to cap mpl to 3.5 or greater.

@WardDeb WardDeb merged commit aca3def into deeptools:develop Sep 26, 2023
@lldelisle lldelisle deleted the fix_matplotlib_3.8 branch September 26, 2023 15:32
@lldelisle lldelisle mentioned this pull request Sep 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lldelisle @WardDeb