Skip to content

Conversation

@WardDeb
Copy link
Member

@WardDeb WardDeb commented Aug 21, 2023

Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :

  • Does the PR contain new feature?
  • Does the PR contain bugfix?
  • Does the PR contain documentation changes?
  • Does the PR contain changes to the galaxy wrapper?

This PR tries to update requirements / python setup to more recent versions (>=3.7).

  1. pyproject.toml file
    • dependencies and metadata are defined in the toml file (setup.py & requirements deprecated)
    • scripts / entrypoints are defined here as well (bin folder deprecated)
    • wheels are built setuptools / toml file now (python >= 3.7)
    • deeptools' version is defined in the toml file as well (no more _version.py, keep importlib as a requirement until we drop python 3.7 support).
    • --version flags have been changed to use importlib in all executables.
    • matplotlib version pin has been removed, some changes in the cm.py for newer version.
  2. CI / github actions
    • nosetests are deprecated and ported to pytests
    • pytests now run on proposed wheel with version 3.7 - 3.11
    • dependency on the custom typescript action (https://github.com/deeptools/github-actions) has been deprecated in favor of micromamba/python/miniconda-setup actions
    • planemo tests and pytests use conda environment(.github/test_and_build.yml), historical 'foo' name is dropped.
    • planemo tests expected pngs are slightly changed (due to mpl updates)
    • expected qual metrics in plotfingerprint changed, not 100% where exactly the rounding difference comes from
    • planemo tests run on galaxy 23.1

@WardDeb
Copy link
Member Author

WardDeb commented Aug 21, 2023

@bgruening Do you mind having a look ?
I'm not sure if the change to 3.10 will bring some difficulties especially with the galaxy version ?

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, a few comments inline :)

Thanks @WardDeb

strategy:
matrix:
python-version: ['3.7']
python-version: ['3.10']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could test multiple versions if we like.
Historically we tested for the lower bound. But we could test for lower and upper-supported python versions.

3.8 and 3.11?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've included 3.7 & 3.11, though I'm not sure how relevant it is at this stage (planemo_combine_outputs): The tests have already ran at that time, right ?

@WardDeb WardDeb changed the title python 3.10 toml install / requirements version boost Aug 25, 2023
@WardDeb WardDeb requested a review from bgruening August 25, 2023 13:58
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks a lot @WardDeb

@WardDeb WardDeb merged commit 3f8010c into deeptools:develop Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants