Skip to content

Conversation

@icebert
Copy link
Contributor

@icebert icebert commented Dec 10, 2020

Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :

  • [ Y] Does the PR contain new feature?
  • [ N] Does the PR contain bugfix?
  • [ Y] Does the PR contain documentation changes?
  • [N ] Does the PR contain changes to the galaxy wrapper?

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @icebert!

action='store_true')

parser.add_argument('--fixedStep',
help='Output in fixed step of bin size (as specified by --binSize), not merging '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone has a better phrasing here that would be great. I think the PR is fine but the sentences is a bit confusing for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WardDeb any idea?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed the wording is a bit confusing.
Perhaps:
'Write out all bins (of size --binSize) instead of merging neighbouring bins with equal values.' ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take it along in develop for now and will make the change afterwards.

@WardDeb WardDeb changed the base branch from master to dev_wd May 12, 2023 11:12
@WardDeb WardDeb changed the base branch from dev_wd to develop May 12, 2023 11:12
@WardDeb WardDeb merged commit 723fcd7 into deeptools:develop May 12, 2023
@WardDeb WardDeb mentioned this pull request May 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants