see_mem_usage: make always work #7688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`logger` is the wrong facility for `see_mem_usage` messages, since it should always print (if `force=True`) and the current implementation doesn't guarantee that leading to wasted dev time puzzling over it. So fixing to use `print` instead.
stas00
requested review from
jeffra
and removed request for
tjruwase and
tohtana
sfc-gh-truwase
approved these changes
Nov 12, 2025
rraminen
pushed a commit
to rraminen/DeepSpeed
that referenced
this pull request
Dec 1, 2025
`logger` is the wrong facility for `see_mem_usage` messages, since it should always print (if `force=True`) and the current implementation doesn't guarantee that leading to wasted dev time puzzling over it. So fixing to use `print` instead. Signed-off-by: rraminen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loggeris the wrong facility forsee_mem_usagemessages, since it should always print (ifforce=True) and the current implementation doesn't guarantee that, leading to wasted dev time puzzling over missing prints. So fixing to useprintinstead.