[modal ci] fixes #7676
Merged
[modal ci] fixes #7676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
stas00
commented
Nov 6, 2025
Comment on lines
24
to
25
| pull_request: | ||
| #pull_request_target: |
Collaborator
Author
There was a problem hiding this comment.
this will be reverted before merge
Collaborator
Author
|
@tjruwase, please have a look - this now works. |
Signed-off-by: Stas Bekman <[email protected]>
sfc-gh-truwase
approved these changes
Nov 6, 2025
Signed-off-by: Stas Bekman <[email protected]>
Collaborator
Author
|
so I had to force merge, since _target can't pass, but the next PR should work after rebasing. |
LckyLke
pushed a commit
to LckyLke/DeepSpeed
that referenced
this pull request
Nov 11, 2025
1. `modal-accelerate` needs now `uv` installed explicitly since the image change to 2025 one. 2. moved accelerate repo cloning into the job, since the original way was incorrect as it was caching some accelerate version and not updating it. 3. annotated that how to actually test the ci work when changing the workflow as `pull_request_target` will not run the updated .py+.yaml files. --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: Luke Friedrichs <[email protected]>
LckyLke
pushed a commit
to LckyLke/DeepSpeed
that referenced
this pull request
Nov 11, 2025
1. `modal-accelerate` needs now `uv` installed explicitly since the image change to 2025 one. 2. moved accelerate repo cloning into the job, since the original way was incorrect as it was caching some accelerate version and not updating it. 3. annotated that how to actually test the ci work when changing the workflow as `pull_request_target` will not run the updated .py+.yaml files. --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: Luke Friedrichs <[email protected]>
rraminen
pushed a commit
to rraminen/DeepSpeed
that referenced
this pull request
Dec 1, 2025
1. `modal-accelerate` needs now `uv` installed explicitly since the image change to 2025 one. 2. moved accelerate repo cloning into the job, since the original way was incorrect as it was caching some accelerate version and not updating it. 3. annotated that how to actually test the ci work when changing the workflow as `pull_request_target` will not run the updated .py+.yaml files. --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: rraminen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modal-accelerateneeds nowuvinstalled explicitly since the image change to 2025 one.pull_request_targetwill not run the updated .py+.yaml files.