leaf modules: explain better #7674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Masahiro's explanation to why that code is there.
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
tohtana
reviewed
Nov 6, 2025
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Signed-off-by: Stas Bekman <[email protected]>
Collaborator
Author
|
@tohtana, this is good now - I fixed the CI issues in another PR. |
LckyLke
pushed a commit
to LckyLke/DeepSpeed
that referenced
this pull request
Nov 11, 2025
add Masahiro's explanation to why that code is there. --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: Luke Friedrichs <[email protected]>
LckyLke
pushed a commit
to LckyLke/DeepSpeed
that referenced
this pull request
Nov 11, 2025
add Masahiro's explanation to why that code is there. --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: Luke Friedrichs <[email protected]>
rraminen
pushed a commit
to rraminen/DeepSpeed
that referenced
this pull request
Dec 1, 2025
add Masahiro's explanation to why that code is there. --------- Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: rraminen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Masahiro's explanation to why that code is there.