[bug]: fixed comm_dtype in extra_large_param_to_reduce #7660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naveenraj Kamalakannan <[email protected]>
rraminen
pushed a commit
to rraminen/DeepSpeed
that referenced
this pull request
Dec 1, 2025
) Fixes deepspeedai#7653 The extra-large params were recorded in `param.dtype` but the reducer looks up using `comm_dtype`. https://github.com/deepspeedai/DeepSpeed/blob/d56e847bac2853d5b8819ce176eeafff65a3798e/deepspeed/runtime/zero/stage_1_and_2.py#L1461 cc @sfc-gh-truwase Signed-off-by: Naveenraj Kamalakannan <[email protected]> Co-authored-by: Masahiro Tanaka <[email protected]> Signed-off-by: rraminen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7653
The extra-large params were recorded in
param.dtypebut the reducer looks up usingcomm_dtype.DeepSpeed/deepspeed/runtime/zero/stage_1_and_2.py
Line 1461 in d56e847
cc @sfc-gh-truwase