ALST/UlyssesSP: more intuitive API wrt variable seqlen #7656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stas Bekman <[email protected]>
2 tasks
tjruwase
approved these changes
Oct 29, 2025
Collaborator
Author
|
Thank you, Tunji! |
rraminen
pushed a commit
to rraminen/DeepSpeed
that referenced
this pull request
Dec 1, 2025
) As I was integrating ALST/Ulysses SP into HF Accelerate/Trainer I noticed that the initial `UlyssesSPAttentionHF.register_with_transformers` API was a bit inflexible/confusing wrt variable seqlen. This PR deprecates the misleading `max_length` arg name, replaces it with `seq_length` and makes the latter optional if `seq_length_is_variable` is True. Updated tests and docs. Signed-off-by: Stas Bekman <[email protected]> Signed-off-by: rraminen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was integrating ALST/Ulysses SP into HF Accelerate/Trainer I noticed that the initial
UlyssesSPAttentionHF.register_with_transformersAPI was a bit inflexible/confusing wrt variable seqlen.This PR deprecates the misleading
max_lengtharg name, replaces it withseq_lengthand makes the latter optional ifseq_length_is_variableis True.Updated tests and docs.