Skip to content

Conversation

@stas00
Copy link
Collaborator

@stas00 stas00 commented Oct 20, 2025

This PR improves a user experience by moving away from reporting a meaningless to user zero parameter id:

AssertionError: The parameter 200 has already been reduced....

towards giving the actual param name:

AssertionError: The parameter lm_head.weight has already been reduced...

this enables the user to start unravelling where the problem is.

@stas00 stas00 changed the title z2: report param name and not id in assert z2: report param name and not zero id in assert Oct 20, 2025
@stas00 stas00 enabled auto-merge (squash) October 20, 2025 20:36
@stas00 stas00 merged commit fc85436 into master Oct 22, 2025
13 checks passed
@stas00 stas00 deleted the stas00-patch-4 branch October 22, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants