Show mismatching values when DeepCompile test fails #7618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masahiro Tanaka <[email protected]>
Signed-off-by: Masahiro Tanaka <[email protected]>
sfc-gh-truwase
approved these changes
Oct 3, 2025
mauryaavinash95
pushed a commit
to DataStates/DeepSpeed
that referenced
this pull request
Oct 4, 2025
This PR improves error message when DeepCompile test fails. Tests of DeepCompile occasionally fail ([example](https://github.com/deepspeedai/DeepSpeed/actions/runs/18160078309/job/51688736712?pr=7604)) because of mismatching loss values. To make sure this is not a synchronization bug that causes `nan` loss values, the change in this PR shows the mismatching values. We can consider increasing the tolerances once we confirm the mismatch is reasonable. --------- Signed-off-by: Masahiro Tanaka <[email protected]>
Liangliang-Ma
pushed a commit
to Liangliang-Ma/DeepSpeed
that referenced
this pull request
Oct 13, 2025
This PR improves error message when DeepCompile test fails. Tests of DeepCompile occasionally fail ([example](https://github.com/deepspeedai/DeepSpeed/actions/runs/18160078309/job/51688736712?pr=7604)) because of mismatching loss values. To make sure this is not a synchronization bug that causes `nan` loss values, the change in this PR shows the mismatching values. We can consider increasing the tolerances once we confirm the mismatch is reasonable. --------- Signed-off-by: Masahiro Tanaka <[email protected]> Signed-off-by: Ma, Liangliang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error message when DeepCompile test fails.
Tests of DeepCompile occasionally fail (example) because of mismatching loss values.
To make sure this is not a synchronization bug that causes
nanloss values, the change in this PR shows the mismatching values. We can consider increasing the tolerances once we confirm the mismatch is reasonable.